-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created new term "Sidecar Container" #3353
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Fernando Harris <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Fernando Harris <[email protected]>
@iamNoah1 , would you please have a look ? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!! LGTM!!
Signed-off-by: Fernando Harris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the content, especially the introduction. Everything you wrote is correct, still, I we have to be a bit picky and more precise.
|
||
## Problem it addresses | ||
|
||
There are scenarios where it is convenient to group [containers](/container/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are scenarios where it is convenient to group [containers](/container/) | |
There are scenarios where it is convenient to group [containers](/container/) and their lifecycle |
## Problem it addresses | ||
|
||
There are scenarios where it is convenient to group [containers](/container/) | ||
to deal with cross-platform requirements or shared functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to deal with cross-platform requirements or shared functionality. | |
to deal with scenarios |
|
||
There are scenarios where it is convenient to group [containers](/container/) | ||
to deal with cross-platform requirements or shared functionality. | ||
Such scenarios include [observability](/observability/) topics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such scenarios include [observability](/observability/) topics |
to deal with cross-platform requirements or shared functionality. | ||
Such scenarios include [observability](/observability/) topics | ||
like logging, monitoring, tracing, but also security, and networking. | ||
For example, when multiple microservices have their sidecar containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we talk already about the solution. This would be where you should show how collecting logs would look without the sidecar container.
|
||
## How it helps | ||
|
||
The term "sidecar" comes from the representation of a classic motorcycle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term "sidecar" comes from the representation of a classic motorcycle |
This approach consists of using a separated process | ||
running on a secondary container to address problems | ||
that aren't unique to a single application | ||
but rather to the entire platform where the application is running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but rather to the entire platform where the application is running. |
We already kinda said that the problems are not unique to an application, but rather cross-platform relevant
including storage and networking, as the main container. | ||
While doing this, it frees the main container to be focused on functional tasks | ||
or exposing business capabilities. | ||
As a secondary container, the "sidecar" takes care of platform related tasks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a secondary container, the "sidecar" takes care of platform related tasks |
redundant
While doing this, it frees the main container to be focused on functional tasks | ||
or exposing business capabilities. | ||
As a secondary container, the "sidecar" takes care of platform related tasks | ||
such as logging, monitoring or security. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
such as logging, monitoring or security. |
but rather to the entire platform where the application is running. | ||
The Sidecar Container will share the same resources, | ||
including storage and networking, as the main container. | ||
While doing this, it frees the main container to be focused on functional tasks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is a bit vague. I would rather be happy to see a more specific example. For instance something like this:
This makes it easy for a logging sidecar to collect logs from the main application without needing to change anything in the main application. The sidecar could read the same directory, the main application writes its logs to.
or exposing business capabilities. | ||
As a secondary container, the "sidecar" takes care of platform related tasks | ||
such as logging, monitoring or security. | ||
It enforces the principle of separation of concerns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you accept my suggested change some comments above this sentence could become redundant.
Describe your changes
Created new term "Sidecar Container"
Related issue number or link (ex:
resolves #issue-number
)resolves #2958
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.